Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fetch initials blacklist from firestore #173

Merged
merged 4 commits into from
Apr 2, 2024
Merged

feat: fetch initials blacklist from firestore #173

merged 4 commits into from
Apr 2, 2024

Conversation

jsgalarraga
Copy link
Member

@jsgalarraga jsgalarraga commented Apr 2, 2024 •
edited
Loading

Description

  • Fetch the initials blacklist from firestore
  • Updated collection names to all be lower camel case
  • Remove api response decryption since we're not encrypting it from the api

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@jsgalarraga jsgalarraga self-assigned this Apr 2, 2024
alestiago
alestiago approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@alestiago alestiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't done an exhaustive review. Looks good overall!

@jsgalarraga jsgalarraga merged commit d63b90f into main Apr 2, 2024
6 checks passed
@jsgalarraga jsgalarraga deleted the feat/fetch-blacklist branch April 2, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alestiago alestiago alestiago approved these changes

@B0berman B0berman Awaiting requested review from B0berman B0berman is a code owner

@AyadLaouissi AyadLaouissi Awaiting requested review from AyadLaouissi AyadLaouissi is a code owner

Assignees

@jsgalarraga jsgalarraga

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsgalarraga @alestiago